Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extra features to Siemens reader. #233

Merged
merged 29 commits into from
Feb 13, 2025

Conversation

chaithyagr
Copy link
Member

We add suppoort to read ACS region (useful for GRAPPA + GoLF and maybe in future EPI)

@chaithyagr chaithyagr self-assigned this Feb 4, 2025
@chaithyagr chaithyagr requested a review from paquiteau February 5, 2025 09:00
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to do for your application. Also, be sure to update the documentation about the extra header field.

Comment on lines 68 to 70
This function is useful when the k-space data has extra samples
mainly as ADC samples at only upto

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish the sentence ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol this is what happens when someone calls me to show their fancy results while writing code :P

@chaithyagr
Copy link
Member Author

@paquiteau can we merge this?

@paquiteau paquiteau self-requested a review February 12, 2025 15:30
@chaithyagr chaithyagr merged commit 01c779f into mind-inria:master Feb 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants